[Buildroot] [PATCH 19/27] autobuild-run: define output directory as part of Builder class

Arnout Vandecappelle arnout at mind.be
Mon Jul 1 22:26:44 UTC 2019



On 29/06/2019 07:02, Atharva Lele wrote:
> Absolute path for output dir is required when using outputdir with
> system commands like make or tail. It was necessary because the
> relative path would be relative to the autobuilder script rather
> than the buildroot source directory.
> 
> It is OK to use absolute path even where it was not used before
> since Python throws away the non-absolute components and uses
> the absolute path for os.path.join() wherever it is used.

 This is not really accurate. It is OK to use an absolute path everywhere since
an absolute path is always correct, nothing more than that. The rest of the
sentence is inaccurate.

> 
> Signed-off-by: Atharva Lele <itsatharva at gmail.com>

[snip]
> @@ -472,9 +468,8 @@ class Builder:
>          monitor_thread_hung_build_flag = Event()
>          monitor_thread_stop_flag = Event()
>          build_monitor = Thread(target=self.stop_on_build_hang,
> -                               args=(monitor_thread_hung_build_flag,
> -                                     monitor_thread_stop_flag,
> -                                     sub, outputdir))
> +                            args=(monitor_thread_hung_build_flag,
> +                                  monitor_thread_stop_flag, sub))

 Here you introduced a whitespace error.

 Regards,
 Arnout

[snip]


More information about the buildroot mailing list