[Buildroot] [PATCH 5/8] package/usb_modeswitch: avoid overriding variables
Peter Korsgaard
peter at korsgaard.com
Tue Jan 29 22:01:37 UTC 2019
>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski at gmail.com> writes:
> Overriding variables in packages recipes is an error-prone practice.
> Current behavior of installing either only as a script or only as a
> binary is intended, as describe in the commit log of "d3e4db4e34
> usb_modeswitch: bump to version 1.2.6" from 2013.
> Rewrite the code to keep the same behavior while replacing variable
> override [1] by conditional assignments [2].
> [1]
> VAR = ...
> if ...
> VAR = ...
> [2]
> if ...
> VAR = ...
> else
> VAR = ...
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>
Committed to 2018.02.x and 2018.11.x, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list