[Buildroot] [PATCH 2/2] utils/get-developers: really make it callable from elsewhere than the toplevel directory
Peter Korsgaard
peter at korsgaard.com
Thu Jan 24 10:59:35 UTC 2019
>>>>> "Peter" == Peter Korsgaard <peter at korsgaard.com> writes:
> Commit 62d5558f76a (utils/get-developers: make it callable from elsewhere
> than the toplevel directory) tried to fix this by passing in the toplevel
> directory when the DEVELOPERS file is parsed.
> Unfortunately this is not enough, as E.G. also the paths listed in the
> patches are relative to the toplevel directory, causing it to not match the
> entries in the DEVELOPERS file.
> In concept this can be fixed by also passing the toplevel directory to the
> Developers class, but the simplest solution is just to chdir to the toplevel
> Buildroot directory before calling any of the getdeveloperlib functions.
> This does require us to finish parsing command line arguments (which opens
> the provided patch files) to not get into trouble with relative paths to
> patches before chdir'ing / initializing getdeveloperlib.
> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
Committed to 2018.02.x and 2018.11.x, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list