[Buildroot] [PATCH v6 1/7] package/compiler-rt: new package

[Matthew Weber]

Romain,

On Thu, Jan 17, 2019 at 8:08 AM Romain Naour <romain.naour at smile.fr> wrote:
>
> Hi Matt,
>
> Le 17/01/2019 à 00:36, Matthew Weber a écrit :
> > Romain,
> >
> >
> > On Wed, Jan 16, 2019 at 3:59 PM Romain Naour <romain.naour at smile.fr> wrote:
> >>
> >> Hi Matt,
> >>
> >> Le 03/01/2019 à 22:52, Matt Weber a écrit :
>
> [...]
>
> >>> +
> >>> +COMPILER_RT_CONF_OPTS=-DCOMPILER_RT_INCLUDE_TESTS=ON \
> >>
> >> Why building the testsuite and tests ?
> >
> > It has been awhile and I don't remember the specific reason.  After
> > glancing at the cmake files, I believe I was using the test builds as
> > a way to verify the libraries could be linked against.  I'll start a
> > test build with that option removed and see if the runtime test has
> > any issues.  I would keep the tests enabled though as it allows the
> > user to see if their llvm setup works for fuzzing without having to
> > debug a custom application too. (Maybe that should be a comment above
> > the conf opts :-)
> >
>
> By default, Buildroot packages should disable tests and testsuite when possible
> in order to keep rootfs small as possible.

I've verified we can disable them without impact.  If I respin another
revision I can set that option to OFF.

>
> That is why several options are set in the package infra (see pkg-cmake.mk):
>    -DBUILD_EXAMPLE=OFF
>    -DBUILD_EXAMPLES=OFF
>    -DBUILD_TEST=OFF
>    -DBUILD_TESTS=OFF
>    -DBUILD_TESTING=OFF
>
> But the question is, do we need a global option to enable building packages
> tests and testsuite?
>
> Otherwise, I'm fine to keep this option enabled if this is useful.

My preference is that we leave them enabled as then the run-time test
would catch additional corner cases as versions are bumped.  :-)

Matt