[Buildroot] [PATCH 00/19] support: limit install-time instrumentation to current package's files (branch yem/files-list-2)

[Yann E. MORIN]

Thomas, All,

On 2019-01-08 16:53 +0100, Thomas De Schampheleire spake thusly:
> El mar., 8 ene. 2019 a las 13:51, Thomas De Schampheleire
> (<patrickdepinguin at gmail.com>) escribió:
> > El lun., 7 ene. 2019 a las 23:05, Yann E. MORIN
> > (<yann.morin.1998 at free.fr>) escribió:
> > > Currently, the instrumentation steps, that we run after a package is
> > > installed, get confused about the files that package may have be
> > > responsible for.
[--SNIP--]
> > > This series is thus an attempt at fixing all those issues.
[--SNIP--]
> > For reference, the discussion thread when commit 7fb6e782542f was submitted:
> > http://lists.busybox.net/pipermail/buildroot/2018-March/215979.html
> > and my comments on moving away from the md5sum to the mtime approach:
> > http://lists.busybox.net/pipermail/buildroot/2018-March/216331.html

I do realise today that I did not reply to you back at that time.
Apologies.

Still I have no idea on how we could have _easily_ fixed the issue
anyway. The solution proposed by Trent would have been way too
complicated to come up with in a timely manner, no md5sum-ing staging/
and host/ would prevent PPD, and thus TLPB, to eventually land.

> > I will be cross-checking this series against these comments, as an
> > accurate list in packages-file-list.txt is important for me. In my
> > current tree, I reverted commit 7fb6e782542f and disabled
> > check-uniq-files on staging and host, to alleviate the time impact but
> > still have an accurate list.
> 
> I finished reviewing, thanks for this interesting series and clear commits.
> 
> Regarding my old comments linked above, I think the packages-file-list
> will still be off if a package installs a file with a fixed timestamp,
> typically a timestamp in the past. I should test this series against
> our use case to see if we actually have such a case, but I'd need to
> do some preparatory work first so it may take some time.

As I already said, we already have the issue with our skeleton, anyway.

For our skeleton, we can probably fix it quite easily with some rsync
trickery (but I could not find how, so far).

But for a more generic solution, we'd need a way to detect files that
were not previously present but now are.

So we'd need to maintain a list of files from before the installation
and another for after the installation. And oh wait, isn't that
basically what we previously did (modulo the md5)? ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'