[Buildroot] [PATCH 03/11] support/download: reintroduce 'source-check' target
Thomas De Schampheleire
patrickdepinguin at gmail.com
Fri Jan 4 09:07:23 UTC 2019
On Thu, Jan 3, 2019, 22:41 Peter Korsgaard <peter at korsgaard.com wrote:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:
>
> Hi,
>
> > But still, at some point, you will want your CI to actually test the
> > change, so you will need to have the stuff downloaded... So, why can't
> > you simply use 'make source && make' ? It would (mostly) have the actual
> > result you are looking for: do the check that everything is available,
> > and if it is, then the build can proceed. If something was missing, that
> > would have bailed out early.
>
> > The only thing that differs with source-check, is that the network will
> > actually be used (boohoo!).
>
> > However, since we added local cache for git, you would not need to fetch
> > much. Also, tarballs (from wget et al) were already cached locally. Of
> > course, that means you'd have to have BR2_DL_DIR in your envioronment,
> > pointing to a dl location that is persistent...
>
> > What is missing (guess it) is a local cache for Hg. I started working on
> > it a while ago (rght after the git cache was merged), but dropped it as
> > I had no way to throughly test it.
>
> > So, if you are really concerned about not exhausting your internal
> > network that much (I know some companies have slow links between remote
> > sites, so I understand [0]), what about you provide an Hg caching like
> > we have for git instead? ;-)
>
> > So, I am definitely not convinced by the need for source-check...
>
> Agreed. Thomas, can you explain in more detail why you think
> source-check is needed?
>
Okay, give me some time, I will gather some numbers and a well-thought-out
response :-)
Best regards,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190104/1f8bbbf1/attachment.html>
More information about the buildroot
mailing list