[Buildroot] [PATCH v3 09/17] package/gqrx: remove unneeded fftw dependency

[Yann E. MORIN]

Thomas, Gwenhaël, All,

On 2018-12-31 14:30 +0100, Thomas Petazzoni spake thusly:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> 
> Thanks to the new fftw package organization, gnuradio already selects
> the appropriate fftw precision, and there is no need to propagate the
> "depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE" that used to be present
> in the gnuradio package.
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

However, Gwenhaël, one question: why does it depend on gnuradio rather
than selecting it (and propagating its dependencies, of course)?

As I understand it, gqrx is an application, and for applications, we try
as much as posiible to have them visible and select the libraries they
need, rather than hide them behind their libs.

Regards,
Yann E. MORIN.

> ---
>  package/gqrx/Config.in | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/package/gqrx/Config.in b/package/gqrx/Config.in
> index 1dc40c6d24..94ccb60d44 100644
> --- a/package/gqrx/Config.in
> +++ b/package/gqrx/Config.in
> @@ -2,13 +2,11 @@ comment "gqrx needs a toolchain w/ C++, threads, wchar"
>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
>  		!BR2_USE_WCHAR
>  
> -comment "gqrx needs qt5, gnuradio, fftw's single precision"
> -	depends on !BR2_PACKAGE_GNURADIO || !BR2_PACKAGE_FFTW_PRECISION_SINGLE || \
> -		!BR2_PACKAGE_QT5
> +comment "gqrx needs qt5, gnuradio"
> +	depends on !BR2_PACKAGE_GNURADIO || !BR2_PACKAGE_QT5
>  
>  config BR2_PACKAGE_GQRX
>  	bool "gqrx"
> -	depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE # gnuradio
>  	depends on BR2_PACKAGE_GNURADIO
>  	depends on BR2_PACKAGE_QT5
>  	depends on BR2_INSTALL_LIBSTDCPP # boost
> -- 
> 2.20.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'