[Buildroot] [PATCH 1/3] runc: depend on linux headers >= 3.11 for O_TMPFILE

Arnout Vandecappelle arnout at mind.be
Wed Feb 20 21:30:26 UTC 2019



On 20/02/2019 09:01, Thomas Petazzoni wrote:
> Hello Christian,
> 
> On Tue, 19 Feb 2019 14:35:28 -0800
> Christian Stewart <christian at paral.in> wrote:
> 
>> Add dependency on headers >= 3.11. O_TMPFILE, required by runc, was not
>> available until this version.
>>
>> Fixes:
>>
>> http://autobuild.buildroot.net/results/63e9d88ae5177541be463f1e2aafec59aa410479
> 
> I don't see how it can fix this build issue, because the defconfig for
> this failure has:
> 
> BR2_TOOLCHAIN_HEADERS_AT_LEAST="3.12"
> 
> so it *is* using kernel headers more recent than 3.11.
> 
> I had a look at your build issue following your e-mail yesterday, and
> indeed O_TMPFILE was added in the kernel headers in 3.11, but
> apparently having 3.11 kernel headers is not sufficient. I suppose some
> code is also needed in the C library, and because the toolchain used by
> this configuration has an old glibc, it doesn't have everything needed
> for O_TMPFILE.

 Darn. So how do we handle that? We don't have anything for GLIBC_AT_LEAST (much
less MUSL_AT_LEAST or UCLIBC_AT_LEAST...). I don't really want to start adding
*those* either...

> 
> So, your patch is OK in the sense that indeed >= 3.11 is needed, but it
> is wrong in the sense that it is not going to fix the build issue
> you're pointing to.

 If it doesn't fix the autobuild issue, it's kind of useless, so I've marked
this patch as Changes Requested.

 Regards,
 Arnout


More information about the buildroot mailing list