[Buildroot] [PATCH 1/1] package/glm: bump to version 0.9.9.3

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Feb 17 14:54:57 UTC 2019


Hello Fabrice,

On Sun, 17 Feb 2019 10:35:29 +0100
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> - Disable tests as they are enabled by default since version 0.9.9.1:
>   https://github.com/g-truc/glm/commit/d307d390193f4027faec48ac79d7f74b2bec6e56
> - Static and shared libraries are always built since version 0.9.9.1:
>   https://github.com/g-truc/glm/commit/a23dd2f800185a5e233534fed82fc5c2840fbe5c
>   So, add a patch to fix this behavior and disable them as GLM is
>   header-ony

I don't understand this. Why does the glm CMakeLists.txt has provision
to build static and shared libraries if it's a header-only library ?

> ++if(BUILD_STATIC_LIBS)
> + add_library(glm_static STATIC ${ROOT_TEXT} ${ROOT_MD} ${ROOT_NAT}
> + 	${ROOT_SOURCE}    ${ROOT_INLINE}    ${ROOT_HEADER}
> + 	${CORE_SOURCE}    ${CORE_INLINE}    ${CORE_HEADER}
> +@@ -51,7 +52,9 @@ add_library(glm_static STATIC ${ROOT_TEXT} ${ROOT_MD} ${ROOT_NAT}
> + 	${GTC_SOURCE}     ${GTC_INLINE}     ${GTC_HEADER}
> + 	${GTX_SOURCE}     ${GTX_INLINE}     ${GTX_HEADER}
> + 	${SIMD_SOURCE}    ${SIMD_INLINE}    ${SIMD_HEADER})

I.e, what is this code doing ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list