[Buildroot] [PATCH] add library xmlsec1

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Feb 10 14:20:19 UTC 2019


Hello Bastian,

On Sun, 10 Feb 2019 15:12:48 +0100
Bastian Breit <bastian.breit.buildroot at gmail.com> wrote:

> I locally fixed the formatting and licence part.

Great, thanks!

> I had some trouble with the mailing list and will use
> bastian.breit.buildroot at gmail.com from now on. 

Which trouble did you encounter ?

> We use libxmlsec1 in
> this context and haven't used another configuration. I am not sure,
> how the library works in other configuration. I would create config
> options for each option based on that list at
> https://www.aleksey.com/xmlsec/faq.html

No you don't have to support all options. If you don't support an
option (like gnutls or gcrypt), then do like you did: disable support
for it explicitly in the .mk file.

> Should I send changes for formatting & licences with a different patch
> or should I send an all in one patch?

Send all in one patch, labeled as "v2", with a changelog below the
"---" sign:

	git format-patch -v2 HEAD^

Edit the 0001-...patch file, and below the --- sign, add some notes
that explains what you changed since v1.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list