[Buildroot] [PATCH] utils/test-pkg: clean output dir for successful builds

[Arnout Vandecappelle]

On 05/02/2019 19:10, Thomas De Schampheleire wrote:
> 
> 
> On Tue, Feb 5, 2019, 17:55 Arnout Vandecappelle <arnout at mind.be
> <mailto:arnout at mind.be> wrote:
> 
> 
> 
>     On 05/02/2019 17:16, Thomas De Schampheleire wrote:
>     > From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com
>     <mailto:thomas.de_schampheleire at nokia.com>>
>     >
>     > test-pkg will use gigabytes of space when testing all toolchains.
>     > Nevertheless, you are normally only interested in the actual build / host
>     > tree when there is a build failure.
> 
>      Well, except in the situation where you're iteratively fixing the package and
>     re-testing with the -p option, no? Then your subsequent attempt would be happy
>     to reuse the build results of all dependencies...
> 
>      So, I think it's better to make this optional - perhaps with a -k,--keep option
>     similar to run-tests.
> 
> 
> While it does not hurt to make it optional, I don't understand your example. If
> your iteratively 'fixing' a package, then the build fails and we don't clean
> anyway. Right?
> 
> But one could indeed imagine iteratively 'changing' a package where intermediate
> iterations actually work and you want to keep the result.

 You still want to re-test the toolchains that worked before. With -p, a
pkg-dirclean is done before building, which is exactly what you need most of the
time.

 Of course, if you're updating dependencies, it's not the best workflow.

 Regards,
 Arnout