[Buildroot] [PATCH v6] testing/infra: split runtime test from BRTest

Arnout Vandecappelle arnout at mind.be
Tue Feb 5 14:29:06 UTC 2019



On 05/02/2019 14:21, Peter Korsgaard wrote:
>>>>>> "Matt" == Matt Weber <matthew.weber at rockwellcollins.com> writes:
> 
>  > From: Ricardo Martincoski <ricardo.martincoski at datacom.ind.br>
>  > Move the setup of emulator to a new class, RuntimeTestBase, that bahaves
> 
> s/bahaves/behaves/
> 
>  > exactly like BRTest currently does.
>  > It will avoid duplicating code when adding a common class to test the
>  > git download infra.
> 
> Sorry for the late feedback, but wouldn't it be a lot simpler/more
> pragmatic to keep the BRTest name for the "common" case, and instead add
> a new parent class with all the common stuff.
> 
> E.G.:
> 
> BaseTest <-- GitTest <- ..
>            |
>             - BRTest <-- TestATop
>                       |
>                        - TestDropbear
>                       |
>                        - ...
> 
> I agree that RuntimeTestBase is maybe a nicer name, but BRTest for
> something where we run a Buildroot output under qemu isn't really bad
> either IMHO.

 I thought of that as well, but then I thought that it would be confusing to add
a superclass. But I hadn't figured out that BRTest would indeed refer to tests
doing a full Buildroot build.

 BaseTest is not that great, though. BRConfigTest maybe? That more accurately
reflects what it does, I think.

 Regards,
 Arnout


More information about the buildroot mailing list