[Buildroot] [PATCH v6] testing/infra: split runtime test from BRTest

[Peter Korsgaard]

>>>>> "Matt" == Matt Weber <matthew.weber at rockwellcollins.com> writes:

 > From: Ricardo Martincoski <ricardo.martincoski at datacom.ind.br>
 > Move the setup of emulator to a new class, RuntimeTestBase, that bahaves

s/bahaves/behaves/

 > exactly like BRTest currently does.
 > It will avoid duplicating code when adding a common class to test the
 > git download infra.

Sorry for the late feedback, but wouldn't it be a lot simpler/more
pragmatic to keep the BRTest name for the "common" case, and instead add
a new parent class with all the common stuff.

E.G.:

BaseTest <-- GitTest <- ..
           |
            - BRTest <-- TestATop
                      |
                       - TestDropbear
                      |
                       - ...

I agree that RuntimeTestBase is maybe a nicer name, but BRTest for
something where we run a Buildroot output under qemu isn't really bad
either IMHO.

-- 
Bye, Peter Korsgaard