[Buildroot] [EXT] Re: [PATCH v2 1/3] package/arm-gnu-rm-toolchain: new package

[Thomas De Schampheleire]

El mar., 5 feb. 2019 a las 10:34, Kostya Porotchkin
(<kostap at marvell.com>) escribió:
>
> Hi, Yann,
>
> > -----Original Message-----
> > From: Yann E. MORIN <yann.morin.1998 at gmail.com> On Behalf Of Yann E.
> > MORIN
> > Sent: Tuesday, February 5, 2019 11:20
> > To: Kostya Porotchkin <kostap at marvell.com>
> > Cc: buildroot at buildroot.org
> > Subject: [EXT] Re: [Buildroot] [PATCH v2 1/3] package/arm-gnu-rm-toolchain:
> > new package
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > Konstantin, All,
> >
> > On 2019-02-05 09:43 +0200, kostap at marvell.com spake thusly:
> > > From: Konstantin Porotchkin <kostap at marvell.com>
> > >
> > > Add cross-compialtion ARM RM toolchain for supporting firmware builds
> > > for Armv8-based SoCs utilizing Cortex-M/Cortex-R service CPUs.
> > > The cross-toolchain used for building Armv8 application CPU code
> > > cannot be used for Cortex-M/Cortex-R 32-bit THUMB code generation.
> > > This patch installs pre-built bate metal ARM GNU-RM toolchain into the
> > > host file system folder $(HOST_DIR)/opt/gcc-arm-none-eabi for covering
> > > the above mentioned cases.
> > >
> > > Signed-off-by: Konstantin Porotchkin <kostap at marvell.com>
> > > ---
> > >  .../arm-gnu-rm-toolchain.hash                    |  2 ++
> > >  .../arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk | 16
> > > ++++++++++++++++
> > >  2 files changed, 18 insertions(+)
> > >  create mode 100644
> > > package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.hash
> > >  create mode 100644
> > > package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk
> > >
> > > diff --git a/package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.hash
> > > b/package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.hash
> > > new file mode 100644
> > > index 0000000000..a08e8e6208
> > > --- /dev/null
> > > +++ b/package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.hash
> > > @@ -0,0 +1,2 @@
> > > +# Locally calculated
> > > +sha256
> > >
> > +bb17109f0ee697254a5d4ae6e5e01440e3ea8f0277f2e8169bf95d07c7d5fe69
> > > +gcc-arm-none-eabi-7-2018-q2-update-linux.tar.bz2
> > > diff --git a/package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk
> > > b/package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk
> > > new file mode 100644
> > > index 0000000000..a72a172fce
> > > --- /dev/null
> > > +++ b/package/arm-gnu-rm-toolchain/arm-gnu-rm-toolchain.mk
> > > @@ -0,0 +1,16 @@
> > >
> > +#########################################################
> > ############
> > > +###########
> > > +#
> > > +# arm-gnu-rm-toolchain
> > > +#
> > >
> > +#########################################################
> > ############
> > > +###########
> > > +
> > > +ARM_GNU_RM_TOOLCHAIN_SITE =
> > > +https://developer.arm.com/-/media/Files/downloads/gnu-rm/7-2018q2
> > > +ARM_GNU_RM_TOOLCHAIN_VERSION = 7-2018-q2-update
> > > +ARM_GNU_RM_TOOLCHAIN_SOURCE =
> > > +gcc-arm-none-eabi-$(ARM_GNU_RM_TOOLCHAIN_VERSION)-
> > linux.tar.bz2
> >
> > You also need to provide the liense, and the URL to the source tarball(s), like:
> >
> >     ARM_GNU_RM_TOOLCHAIN_LICENSE = so-and-so
> >     ARM_GNU_RM_TOOLCHAIN_LICENSE_FILES = some/file some/other/file
> >     ARM_GNU_RM_TOOLCHAIN_ACTUAL_SOURCE_TARBALL =
> > http://URL/of/source.tar
> >
> > Note that you will need to also add a hash for the actual source tarball as
> > well.
> [KP] OK, will work on it
> >
> > > +define HOST_ARM_GNU_RM_TOOLCHAIN_INSTALL_CMDS
> > > +   mkdir -p $(HOST_DIR)/opt/gcc-arm-none-eabi/
> > > +   cp -a $(@D)/* $(HOST_DIR)/opt/gcc-arm-none-eabi/
> >
> > You should rather use a mv to avoid the size duplication, like we do in the
> > external-toolchain infra for the main toolchain.
> [KP] Yes, already doing so following Thomas review
> >
> > Also, why do you not install them in $(HOST_DIR)? As it is as you did, other
> > packages have to know about this specific location, which is not entirely
> > nice... However, if installing in $(HOST_DIR), maybe we have to be carefull
> > about not causing name-clashing with other host stuff...
> [KP] Again, after Thomas review I am adding symbolic links from the toolchain executables in "bin" folder to the $(HOST_DIR)/bin
> Will it be enough? I am noty sure if it's good to just extract the entire package to the $(HOST_DIR)/.
> Please correct me if I am wrong.
>

Yes, I think that we should only have symlinks there, not the actual
extracted tarball. This follows the same approach as the internal
toolchain.

Best regards,
Thomas