[Buildroot] [PATCH 1/3] aircrack-ng: add optional hwloc dependency

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sat Feb 2 14:03:20 UTC 2019


Hello Fabrice,

On Wed, 30 Jan 2019 18:28:33 +0100
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> hwloc dependency has been added in version 1.4 with
> https://github.com/aircrack-ng/aircrack-ng/commit/c31b27449962bc69638b32ec14e0ffdb8997dfcf
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  package/aircrack-ng/aircrack-ng.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Series applied, thanks. I hesitated a bit on PATCH 2/3, because we
typically don't really care about building tests in the context of
Buildroot. However, since unit tests in aircrack-ng are unconditionally
built, and the result depends on whether cmoka is available or not, it
makes sense to have it as an optional dependency.

Also, could you start using the convention of "package/<foo>" prefixes
for your commit titles ? We have finally standardized a bit the format
of commit titles, see:

  http://nightly.buildroot.org/manual.html#submitting-patches

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list