[Buildroot] [PATCH v3 for-next 00/11] gitlab Qemu runtime testing

[Arnout Vandecappelle]

On 14/12/2019 21:48, Romain Naour wrote:
> Hi,
> 
> Le 17/11/2019 à 21:18, Romain Naour a écrit :
>> This new iteration take into account the previous review with
>> some additional rework.
>>
>> This series start by removing useless host-qemu build for
>> m68k_q800, enable serial console for x86/x86_64 and some
>> refactoring for csky and arm-versatile.
>>
>> Replace the readme.txt file by a bash script that ease starting
>> Qemu. Then a new comment is added to each Qemu defconfig files in
>> order to provide the path to this new script.
>> This path help to link each Qemu defconfig with it's own script.
>>
>> Add new python script to be used by gitlab to start Qemu when
>> a Qemu defconfig is built.
>>
>> Finally add this new python script to .gitlab-ci.yml.
>>
>> http://lists.busybox.net/pipermail/buildroot/2019-May/249432.html
>>
> 
> I discussed about this series with Jeremy and he suggest to add the Qemu command
> line into the Qemu's defconfig file (add a new Kconfig option).
> With that, we can even add a new Makefile target "make run-qemu" to start Qemu
> when the Qemu command line is set in the defconfig (this would avoid adding
> several launch.sh script).

So something like

config BR2_PACKAGE_HOST_QEMU_LAUNCH_ARGS
	string "qemu launch command"
	help
	  Command to launch qemu. If this is defined, 'make run-qemu' can be
	  used to build everything and launch qemu.


HOST_QEMU_LAUNCH_ARGS = $(call qstrip,$(BR2_PACKAGE_HOST_QEMU_LAUNCH_ARGS))
ifneq ($(HOST_QEMU_LAUNCH_ARGS),)
run-qemu: world
	$(Q)$(HOST_QEMU) <kernel args> <rootfs args> $(HOST_QEMU_LAUNCH_ARGS)
endif



Looks like a good idea indeed!

 Regards,
 Arnout