[Buildroot] [PATCH 05/12] arch/arch.mk.xtensa: fix usage of arch-xtensa-overlay-extract

Max Filippov jcmvbkbc at gmail.com
Tue Dec 10 22:09:29 UTC 2019


On Tue, Dec 10, 2019 at 2:00 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> arch-xtensa-overlay-extract was used in gcc, linux, uboot, binutils
> and gdb without properly accouting for the package dependencies that
> may be needed to extract the overlay tarball.
>
> This commit fixes that by introducing an
> ARCH_XTENSA_OVERLAY_EXTRACT_DEPENDENCIES variable in arch.mk.xtensa,
> and then use it where appropriate in gcc, linux, uboot, binutils and
> gdb.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> ---
> Note: if this is preferred, we could avoid adding the
> ARCH_XTENSA_OVERLAY_EXTRACT_DEPENDENCIES variable, and directly call
> extractor-pkg-dependency from each of gcc, linux, uboot, binutils and
> gdb. Having an intermediate variable felt a bit simpler/cleaner, but I
> wouldn't mind changing it.
> ---
>  arch/arch.mk.xtensa                    | 2 ++
>  boot/uboot/uboot.mk                    | 1 +
>  linux/linux.mk                         | 1 +
>  package/binutils/binutils.mk           | 2 ++
>  package/gcc/gcc-final/gcc-final.mk     | 1 +
>  package/gcc/gcc-initial/gcc-initial.mk | 1 +
>  package/gdb/gdb.mk                     | 2 ++
>  7 files changed, 10 insertions(+)

Reviewed-by: Max Filippov <jcmvbkbc at gmail.com>

-- 
Thanks.
-- Max


More information about the buildroot mailing list