[Buildroot] [PATCH 2/5] package/shairport-sync: make libdaemon an optional dependency

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Dec 8 22:23:30 UTC 2019


On Tue,  3 Dec 2019 11:53:38 +0100
Jörg Krause <joerg.krause at embedded.rocks> wrote:

>  SHAIRPORT_SYNC_LICENSE = MIT, BSD-3-Clause
>  SHAIRPORT_SYNC_LICENSE_FILES = LICENSES
> -SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf
> +SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig popt host-pkgconf
>  
>  # git clone, no configure
>  SHAIRPORT_SYNC_AUTORECONF = YES
> @@ -33,6 +33,11 @@ else
>  SHAIRPORT_SYNC_CONF_OPTS += --with-tinysvcmdns
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBDAEMON),y)
> +SHAIRPORT_SYNC_DEPENDENCIES += libdaemon
> +SHAIRPORT_SYNC_CONF_OPTS += --with-libdaemon
> +endif

I've applied, but it would be nice to make shairport-sync follow the
same convention as other packages: explicitly pass --without-<foo> when
the relevant dependencies are not available (not just for
--with-libdaemon, but similarly for other features).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list