[Buildroot] [PATCH v5 1/1] package/grpc: bump to version 1.25.0

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Dec 8 14:42:36 UTC 2019


On Fri,  6 Dec 2019 14:25:49 -0800
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett at gmail.com>
> 
> Other changes:
>   - Remove upstream patch 0004-Fix-gettid-naming-conflict.patch
>   - Remove upstream patch 0005-Rename-gettid-functions.patch
>   - Add a check for BR2_TOOLCHAIN_GCC_AT_LEAST_5 in grpc.mk. If the selected
>     toolchain is not at least version 5 or higher

... and the selected optimization level is -Os

>, set the GRPC_CFLAGS and
>     GRPC_CXXFLAGS optimizations to -O3. This check prevents the following error:
>       error: failure memory model cannot be stronger than success memory
>       model for '__atomic_compare_exchange'
> 
> +# Toolchains older than gcc5 will fail to compile with -0s due to:
> +# error: failure memory model cannot be stronger than success memory model for
> +# '__atomic_compare_exchange'
> +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5):$(BR2_OPTIMIZE_S),:y)
> +GRPC_CFLAGS += -O3
> +GRPC_CXXFLAGS += -O3

-O3 is quite aggressive, so I changed to -O2, fixed the commit log, and applied.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list