[Buildroot] [PATCH 1/1] package/arptables: bump to version 0.0.5

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Dec 5 22:00:36 UTC 2019


Hello,

+Yann, Arnout, Peter in Cc.

On Wed,  4 Dec 2019 20:11:44 +0100
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> diff --git a/package/arptables/Config.in b/package/arptables/Config.in
> index 873e791e81..aeb7250a72 100644
> --- a/package/arptables/Config.in
> +++ b/package/arptables/Config.in
> @@ -1,7 +1,12 @@
>  config BR2_PACKAGE_ARPTABLES
> -	bool "arptables"
> +	bool "arptables-legacy"

We normally want to have the package Config.in option name match the
package name, which would no longer be the case here.

>  	depends on BR2_USE_MMU # needs fork()
>  	help
> -	  Tool to set up, maintain, and inspect the tables of ARP rules.
> +	  Legacy tool to set up, maintain, and inspect the tables of ARP
> +	  rules.
>  
> -	  http://ebtables.sourceforge.net
> +	  A more uptodate client of the arptables tool is provided in
> +	  the iptables package. The new tool was formerly known as
> +	  arptables-compat.

Arnout, Peter, Yann, considering the change to the package, does it
make sense to rename it entirely to arptables-legacy ? Or should we
take Fabrice's approach, i.e keep the package name as-is, and just as
an exception change the option prompt ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list