[Buildroot] [PATCH 1/2] package/pkg-python: use HOST_CONFIGURE_OPTS for distutils

Arnout Vandecappelle arnout at mind.be
Thu Dec 5 21:45:04 UTC 2019



On 04/12/2019 15:12, Ryan Barnett wrote:
> On Mon, Nov 11, 2019 at 8:06 AM Ryan Barnett
> <ryan.barnett at rockwellcollins.com> wrote:
>>
>> When building host python packages, we need to ensure that distutils
>> package types utilize HOST_CONFIGURE_OPTS. This ensures that the
>> correct linker and compiler environment variables are set to compile
>> utilizing the host directory.
>>
>> It was discovered that when compiling a host-python package, it was
>> using linking against the build machines library folder instead of the
>> host folder because LDFLAGS was not properly set and was improperly
>> detecting whether or not a shared or static library was present in the
>> host folder.
> 
> Is there any feedback on this approach to compiling a host python
> distutils packages?

 As such it seems like the right thing to do. However, it makes me wonder

- why this is not needed for setuptools;

- why we don't pass TARGET_CONFIGURE_OPTS in the environment for the target.

 Regards,
 Arnout

> 
> Or is it preferred to explicitly pass the LDFLAGS variable in the DISTUTILS_ENV?
> 
>> Signed-off-by: Ryan Barnett <ryan.barnett at rockwellcollins.com>
>> ---
>>  package/pkg-python.mk | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/pkg-python.mk b/package/pkg-python.mk
>> index be1ce071df..8e4c7e5795 100644
>> --- a/package/pkg-python.mk
>> +++ b/package/pkg-python.mk
>> @@ -52,7 +52,8 @@ PKG_PYTHON_DISTUTILS_INSTALL_STAGING_OPTS = \
>>  # Host distutils-based packages
>>  HOST_PKG_PYTHON_DISTUTILS_ENV = \
>>         PATH=$(BR_PATH) \
>> -       PYTHONNOUSERSITE=1
>> +       PYTHONNOUSERSITE=1 \
>> +       $(HOST_CONFIGURE_OPTS)
>>
>>  HOST_PKG_PYTHON_DISTUTILS_INSTALL_OPTS = \
>>         --prefix=$(HOST_DIR)
>> --
>> 2.18.0
>>
> 
> Thanks,
> -Ryan
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 


More information about the buildroot mailing list