[Buildroot] [PATCH 6/7] libnetconf2: adjust dependencies
Heiko.Thiery at kontron.com
Wed Dec 4 13:11:45 UTC 2019
> -----Ursprüngliche Nachricht-----
> Von: Jan Kundrát [mailto:jan.kundrat at cesnet.cz]
> Gesendet: Mittwoch, 4. Dezember 2019 14:01
> An: Heiko Thiery
> Cc: buildroot at buildroot.org; Fabrice Fontaine
> Betreff: Re: [Buildroot] [PATCH 6/7] libnetconf2: adjust dependencies
> > The intention was to be able to select the SSH/TLS support by
> > providing/selecting the dependent package.
> > Do you think that is not reasonable?
> I think that the code in current buildroot does not enforce this. I.e., in case I
> have neither openssl nor libssh+server already selected, I will end up with a
> libnetconf2 which cannot do anything. I think that that is confusing.
> There are other options, of course:
> - We could add nested suboptions below BR2_PACKAGE_LIBNETCONF2 which
> would pick the corresponding depenency. That way, people would at least have
> a hint that they should drill down within KConfig and notice that there are two
> options. Both of these could be checked by default. Disadvantage: if the
> libssh+server or openssl gets enabled later, there's a risk that these two get out
> of sync.
> - We coud just add a hard dependency on both. That IMHO also makes sense
> because I have a feeling that the majority of people actually want both ways.
Just tried to add you're patch and see that with that at least the package testing (utils/test-pkg -p sysrep) will not work without providing a config-snippet that enables one of them (ssl or ssh).
@thomas: is that a valid way (package cannot be tested without config-snippet) or do we have to select the required dependencies to have the test abilitiy?
More information about the buildroot