[Buildroot] [PATCH 1/3] package/nodejs: properly pass the --with-arm-float-abi on ARM

Peter Korsgaard peter at korsgaard.com
Tue Dec 3 15:34:31 UTC 2019

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > When commit 0064132ba032da39cefa4fffe59c31a71d1f1ddb introduced ARM64
 > support in nodejs.mk, it incorrectly kept the NODEJS_ARM_FP
 > definition. This variable is used to pass --with-arm-float-abi, which
 > in NodeJS's configure.py script is only used when --dest-cpu=arm, and
 > not when --dest-cpu=arm64.

 > So we are passing --with-arm-float-abi=<something> for ARM64, which
 > has no effect, and we are no longer passing it on ARM.

 > This commit fixes that by putting the NODEJS_ARM_FP definition back at
 > the right location.

 > Fixes:

 >    0064132ba032da39cefa4fffe59c31a71d1f1ddb

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Committed to 2019.02.x and 2019.08.x, thanks.

Bye, Peter Korsgaard

More information about the buildroot mailing list