[Buildroot] [PATCH 1/1] package/tini: compile executable static
arnout at mind.be
Tue Dec 3 13:29:52 UTC 2019
On 03/12/2019 14:14, Simon Rowe wrote:
> On 01/12/2019 14:41, Arnout Vandecappelle wrote:
>> Could you check with BR2_SHARED_LIBS=y and the current patch if it's possible
>> to build tini for all cases? I.e., external toolchain, internal with musl,
>> glibc, uClibc. If not, then you can make it conditional on !shared like this:
>> $(if $(BR2_SHARED_LIBS),,-static)
> I've run the current patch with the following toolchains
> * internal, only shared libraries, musl
> * internal, only shared libraries, uClibc
> * internal, only shared libraries, glibc
> * external, only shared libraries, musl
> and tini is built correctly.
So the patch was OK, just the commit message should be updated.
>> And of course, we still need an explanation why it is needed after all while
>> before we thought it wasn't.
> Does this need an expansion of the commit message or something elsewhere?
More information about the buildroot