[Buildroot] [PATCH 1/1] package/openjdk: modify site from mirror to official repos

Matthew Weber matthew.weber at rockwellcollins.com
Mon Dec 2 13:57:07 UTC 2019


Tudor,



On Mon, Dec 2, 2019 at 12:09 AM Tudor Holton <tudor at tudorholton.com> wrote:
>
> On 2019-12-02 01:18, Arnout Vandecappelle wrote:
> > On 27/11/2019 06:39, Tudor Holton wrote:

[snip]

> >> @@ -7,7 +7,10 @@
> >>  OPENJDK_VERSION_MAJOR = 12.0.2
> >>  OPENJDK_VERSION_MINOR = 10
> >>  OPENJDK_VERSION = $(OPENJDK_VERSION_MAJOR)+$(OPENJDK_VERSION_MINOR)
> >> -OPENJDK_SITE = $(call
> >> github,AdoptOpenJDK,openjdk-jdk12u,jdk-$(OPENJDK_VERSION))
> >> +OPENJDK_PROJECT = jdk-updates
> >> +OPENJDK_RELEASE = jdk12u
> >
> >  Is it relevant to create variables for these? Just use them directly
> > in the
> > _SITE, like we do for most other packages.
> >
> >
>
> This was inspired by a few other buildroot openjdk packages that have
> been floating around the internet.
>
> It's more a style choice, but also an understanding of the upstream
> repos layout:
>
> Since OpenJDK has multiple streams this may become needed later on.
> Things like aarch32 aren't in jdk-updates (yet).  Config.in may
> eventually be able to select the project and release, but I was trying
> to keep this all as close to the current version as possible.  Don't
> forget, also, that OpenJDK now has LTS releases, which I think would be
> preferable, but there will always be a demand for newer releases also.

If you could, please verify the openjdk run-tests test case still
passes after this site change.  From within your buildroot clone with
this patchset applied, run the following.

./support/testing/run-tests -d ./dl/ -k -o test_dir
tests.package.test_openjdk.TestOpenJdk

Regards,
Matt


More information about the buildroot mailing list