[Buildroot] [PATCH v2 5/7] package/prboom: avoid using hardcoded optimization flags

[Thomas Petazzoni]

On Wed, 26 Jun 2019 14:58:58 +0200
Giulio Benetti <giulio.benetti at micronovasrl.com> wrote:

> Package prboom builds using -O2 flag ignoring Buildroot settings, this
> is due to the fact that -O2 is appended at the end of compiler flags.
> 
> Remove -O2 from 'configure.ac' file and set PRBOOM_AUTORECONF to YES,
> this way CFLAGS_OPTS will contain Buildroot TARGET_CFLAGS.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti at micronovasrl.com>

Your proposed solution is not ideal, because it really only prevents
prboom from adding -O2, but not any other option. A better solution
would have been to make sure that CFLAGS passed as ./configure
environment or arguments appear *after* the CFLAGS defined by the
configure.ac, so they can all be overridden. But well, that is too much
effort for a completely unmaintained piece of software, so I applied
your patch as-is.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com