[Buildroot] [PATCH 1/2] package/icu: Fix nios2 build

Bernd Kuhls bernd.kuhls at t-online.de
Sat Aug 3 07:12:35 UTC 2019


Hi Thomas,

Am Sat, 03 Aug 2019 08:46:52 +0200 schrieb Thomas Petazzoni:

> What is ICU-20751 ? It's not clear if the patch comes from upstream or
> not, since you are the author of patch.

ICU-20751 is the name of my bug report:
https://unicode-org.atlassian.net/browse/ICU-20751

The project mandats that patch subjects start with the name of the ticket:
http://site.icu-project.org/repository/gitdev
"Always prefix your commit statements with the Jira ticket number using 
this pattern (including the space after the number; note: no colon): 
ICU-23456 what I changed"

> Indeed, I see the nios2 and xtensa fixes are not the same, so I guess
> they have a different double conversion behavior, but how did you figure
> this out ?

Yes, the fix is the same, I split it into two pull requests, but they 
patch the same part of the long ifdef statement and the project allows: 
"You can have multiple pull requests per ticket."

> If it's an upstream fix, could you share a link to it ?

No, the patches are authored by me and sent upstream as pull requests.
Ah, and here is the point: I forgot to add the pull request URL to the 
patches, sorry, sent v2.

Regards, Bernd



More information about the buildroot mailing list