[Buildroot] [PATCH v2] qemu: fix host virtfs option

Peter Korsgaard peter at korsgaard.com
Thu Aug 1 17:55:57 UTC 2019


>>>>> "Vincent" == Vincent Stehlé <vincent.stehle at arm.com> writes:

 > Fix the build of host-qemu with virtfs enabled: fix a typo in makefile
 > conditional and add a dependency on host-libcap.

 > The virtfs configuration option was added by commit e0f49e648401
 > ("package/qemu: add option to enable virtual filesystem in host qemu").

 > Signed-off-by: Vincent Stehlé <vincent.stehle at arm.com>
 > Cc: Etienne Carriere <etienne.carriere at linaro.org>

 > ---
 > Changes v1 -> v2:
 >   - Forcibly disable virtfs when config option is =n rather than letting
 >     qemu auto-detect (as per Thomas' feedback)

 >  package/qemu/qemu.mk | 5 ++++-
 >  1 file changed, 4 insertions(+), 1 deletion(-)

 > diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
 > index 73e0778d73..2c11f64ad0 100644
 > --- a/package/qemu/qemu.mk
 > +++ b/package/qemu/qemu.mk
 > @@ -271,8 +271,11 @@ HOST_QEMU_OPTS += --enable-vde
 >  HOST_QEMU_DEPENDENCIES += host-vde2
 >  endif
 
 > -ifdef ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
 > +ifeq ($(BR2_PACKAGE_HOST_QEMU_VIRTFS),y)
 >  HOST_QEMU_OPTS += --enable-virtfs
 > +HOST_QEMU_DEPENDENCIES += host-libcap

I was going to say that we also need host-attr, but looking closer at
the configure step I see that the xattr support in glibc is also
accepted.

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list