[Buildroot] [PATCH] linux-tools/perf: Respect TARGET_CFLAGS

[Yann E. MORIN]

Arnout, Alexey, All,

On 2019-04-27 19:39 +0200, Arnout Vandecappelle spake thusly:
> On 26/04/2019 08:30, Alexey Brodkin wrote:
[--SNIP--]
> >>> The change is OK, but I believe that if -matomic is really a
> >>> core/important CFLAGS on ARC, then we should ideally pass it through
> >>> the toolchain wrapper, so that we are sure it is always passed.
> >>> Arnout, what do you think?
> >>  +1.
> >>  Thomas, last year we made a beginning of deciding what should go through the
> >> wrapper and what through CFLAGS, but I'm not sure if we ever got to a conclusion?
> > So are we going to wait for some infrastructure changes or
> > shall we first fix the problem at hand with broken perf build to ARC700?
> 
>  It's not really infrastructure changes. Rather, it is a better way to fix the
> issue.
> 
>  You just need to move the -matomic from TARGET_ABI to TOOLCHAIN_WRAPPER_OPTS.
> 
>  The only tricky part is where that should be done. I think arch/arch.mk.arc
> would be the right place. But that indeed requires an infrastructural change,
> because the TOOLCHAIN_WRAPPER_OPTS = ... in toolchain-wrapper.mk has to change
> into a +=.

I'm not too fond of this, but what about the following:

diff --git a/arch/arch.mk.arc b/arch/arch.mk.arc
new file mode 100644
index 0000000000..83503841b6
--- /dev/null
+++ b/arch/arch.mk.arc
@@ -0,0 +1,3 @@
+ifeq ($(BR2_arcle),y)
+ARCH_TOOLCHAIN_WRAPPER_OPTS = -matomic
+endif
diff --git a/toolchain/toolchain-wrapper.mk
b/toolchain/toolchain-wrapper.mk
index ca66fa7ba4..8f872506ec 100644
--- a/toolchain/toolchain-wrapper.mk
+++ b/toolchain/toolchain-wrapper.mk
@@ -17,6 +17,7 @@ TOOLCHAIN_WRAPPER_ARGS =
$($(PKG)_TOOLCHAIN_WRAPPER_ARGS)
 TOOLCHAIN_WRAPPER_ARGS += -DBR_SYSROOT='"$(STAGING_SUBDIR)"'
 
 TOOLCHAIN_WRAPPER_OPTS = \
+   $(ARCH_TOOLCHAIN_WRAPPER_OPTS) \
    $(call qstrip,$(BR2_SSP_OPTION)) \
    $(call qstrip,$(BR2_TARGET_OPTIMIZATION))
 
Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'