[Buildroot] [PATCH 3/4] package/bind: don't enable server by default

Arnout Vandecappelle arnout at mind.be
Wed Apr 24 20:56:03 UTC 2019



On 24/04/2019 22:36, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 23 Apr 2019 23:24:05 +0200
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
> 
>> Don't enable server by default as dhcp will now select bind to use the
>> bind libraries
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
>> ---
>>  package/bind/Config.in | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/package/bind/Config.in b/package/bind/Config.in
>> index 60546f691b..6d4ee2e6d7 100644
>> --- a/package/bind/Config.in
>> +++ b/package/bind/Config.in
>> @@ -28,7 +28,6 @@ if BR2_PACKAGE_BIND
>>  
>>  config BR2_PACKAGE_BIND_SERVER
>>  	bool "Install server components"
>> -	default y
> 
> This will break existing defconfigs which did not explicitly enable
> BR2_PACKAGE_BIND_SERVER because it was implicitly enabled when
> BR2_PACKAGE_BIND=y. But I don't see a good solution to avoid that. We
> certainly don't want BR2_PACKAGE_DHCP=y to install the full BIND server.
> 
> So to me, it's an acceptable trade-off. I've Cc'ed Arnout, Peter and
> Yann to see what they think.

 Although not documented anywhere, in my opinion a defconfig is not supposed to
be stable over upgrades. When upgrading, you should use a full config.

 I do the same for the kernel as well.

 I also always do a diffconfig between old and new and try to understand the
differences.

 Regards,
 Arnout



More information about the buildroot mailing list