[Buildroot] [PATCH 1/1] package/wireshark: enable back static build

[Fabrice Fontaine]

Le mar. 16 avr. 2019 à 21:46, Arnout Vandecappelle <arnout at mind.be> a écrit :
>
>
>
> On 16/04/2019 11:41, Fabrice Fontaine wrote:
> > +# Disable plugins as some of them (like l16mono) can't be built statically
> > +ifeq ($(BR2_STATIC_LIBS),y)
> > +WIRESHARK_CONF_OPTS += \
> > +     -DENABLE_PLUGINS=OFF \
> > +     -DENABLE_STATIC=ON
> > +else
> > +WIRESHARK_CONF_OPTS += \
> > +     -DENABLE_PLUGINS=ON \
> > +     -DENABLE_STATIC=OFF
>
>  I don't know what this option does, but is it the appropriate thing to do in
> the STATIC_SHARED case?
ENABLE_STATIC is a wrapper to  the standard BUILD_SHARED_LIBS variable:
if(ENABLE_STATIC)
    set(BUILD_SHARED_LIBS 0)
else()
    set(BUILD_SHARED_LIBS 1)
endif()

I think that our policy is to set BUILD_SHARED_LIBS to ON in the
STATIC_SHARED context.
>
>  Regards,
>  Arnout
>
> > +endif
Best Regards,

Fabrice