[Buildroot] [PATCH v2, 1/1] package/ngircd: fix static build with openssl and atomic

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Apr 15 21:14:16 UTC 2019


On Mon, 15 Apr 2019 23:08:00 +0200
Arnout Vandecappelle <arnout at mind.be> wrote:

> > package/ngircd/ngircd.mk:23: use $() to delimit variables, not ${}
> > package/ngircd/ngircd.mk:26: use $() to delimit variables, not ${}  
> 
>  Huh? How could this ever have worked? make will replace the ${SERIAL_TESTS}
> with the empty string, since the SERIAL_TESTS variable is not defined. Fabrice,
> did you actually test this? Or maybe the SERIAL_TESTS is empty anyway?

SERIAL_TESTS would be "serial-tests" in our case:

  https://github.com/ngircd/ngircd/blob/master/autogen.sh#L190

https://www.gnu.org/software/automake/manual/html_node/Serial-Test-Harness.html

I guess it's only used when you run "make check", so we don't really
care in the context of Buildroot.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list