[Buildroot] [PATCH v3 2/2] Generating the .gitlab-ci.yml file
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Thu Apr 11 16:22:25 UTC 2019
Hello,
On Thu, 11 Apr 2019 17:58:05 +0200
Youssef at smile.fr, Harmouch at smile.fr, youssef.harmouch at smile.fr wrote:
> From: youssef <youssef.harmouch at smile.fr>
>
> Signed-off-by: youssef <youssef.harmouch at smile.fr>
Thanks for your patch, but there are several problems with it:
(1) It should be squashed into the patch introducing the test
(2) The Signed-off-by line has some spurious spaces at the beginning
(3) The From: and Signed-off-by should use your complete real name
(i.e first name + last name)
I will fix this up myself when applying, so these are only
recommendations for future patches.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list