[Buildroot] [PATCH 10/10] infra: introduce top-level, global show-info

[Thomas De Schampheleire]

El dom., 7 abr. 2019 a las 13:51, Yann E. MORIN
(<yann.morin.1998 at free.fr>) escribió:
>
> Now that packages and filesystems can report their recursive info, use
> that to dump the whole info as a valid JSOn array.

JSON

>
> As it is rather complex to ensure soemthing is run before every rules

something

> (to display the eldin opening '[' so as to have a valid JSON array),

I don't know what you wanted to say for 'eldin'.

> re-enter the Makefile and mangle the output with a sed expression, that:
>
>   - 0,/^/s//[\n/;   inserts a '[' before the first line,
>   - $!s/$/,/;       appends a ',' at the end of every lines but the last,
>   - $s/$/\n]/       appends a ']' after the last line.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Arnout Vandecappelle <arnout at mind.be>
> ---
>  Makefile | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 60bf7d7d08..13c4390ae4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -876,6 +876,12 @@ graph-depends-requirements:
>         @dot -? >/dev/null 2>&1 || \
>                 { echo "ERROR: The 'dot' program from Graphviz is needed for graph-depends" >&2; exit 1; }
>
> +.PHONY: show-info _show-info-private
> +show-info:
> +       @$(MAKE) -C $(CONFIG_DIR) _show-info-private |sed -r -e '0,/^/s//[\n/; $$!s/$$/,/; $$s/$$/\n]/'

This should have an explicit '-s' argument, otherwise the output is:

[
make[1]: Entering directory '/home/tdescham/repo/contrib/buildroot',
...
(JSON)
...
make[1]: Leaving directory '/home/tdescham/repo/contrib/buildroot'
]

which is not valid json.

With -s, I validated that the output is valid by piping 'make
show-info' to 'jq .'

> +_show-info-private: $(patsubst %,%-show-recursive-info,$(PACKAGES) $(TARGETS_ROOTFS))
> +       @:
> +
>  .PHONY: show-dependency-tree
>  show-dependency-tree: $(patsubst %,%-show-dependency-tree,$(PACKAGES) $(TARGETS_ROOTFS))
>         @:
> --
> 2.14.1
>