[Buildroot] [PATCH 02/10] infra/pkg-download: make the URI list a callable macro

[Thomas De Schampheleire]

El dom., 7 abr. 2019 a las 13:51, Yann E. MORIN
(<yann.morin.1998 at free.fr>) escribió:
>
> Currently, that variable is context-dependent, as it expects the PKG
> variable to exist and be defined to the current package.
>
> This is not so clean, so change the variable to a callable macro.
>
> Adapt the caller accordingly.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Arnout Vandecappelle <arnout at mind.be>
> ---
>  package/pkg-download.mk | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index f9411213b6..611df5f982 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -71,11 +71,17 @@ export BR_NO_CHECK_HASH_FOR =
>  #
>  # Argument 1 is the source location
>  #
> +#
> +# DOWNLOAD_URIS - List the candidates URIs where to get the package from:
> +#
> +# Argument 1 is the source location
> +# Argument 2 is the upper-case package name
> +#
>  ################################################################################

Here I think it makes sense to split the comment. The part about
'DOWNLOAD' can move below to just above the 'DOWNLOAD' macro, and
DOWNLOAD_URIS remains here. The text listing the three types of
download locations could perhaps move to the DOWNLOAD_URIS part.