[Buildroot] [git commit] package/gettext: turn into virtual package

Vadim Kochan vadim4j at gmail.com
Sun Apr 7 23:01:29 UTC 2019


Hi Romain, All

On Mon, Apr 8, 2019 at 12:43 AM Romain Naour <romain.naour at gmail.com> wrote:
>
> Hi, All
>
> Le 31/03/2019 à 14:04, Thomas Petazzoni a écrit :
> > commit: https://git.buildroot.net/buildroot/commit/?id=ea1e7ee6068265d3f8ade97a387d77c77335b38e
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> >
> > Re-work gettext to be a virtual package which may allow to use
> > different gettext's providers, and rename the original one into
> > gettext-gnu package.
> >
> > Signed-off-by: Vadim Kochan <vadim4j at gmail.com>
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> > ---
>
> > +ifeq ($(BR2_PACKAGE_GETTEXT_GNU),y)
> >  GETTEXTIZE = $(HOST_CONFIGURE_OPTS) AUTOM4TE=$(HOST_DIR)/bin/autom4te $(HOST_DIR)/bin/gettextize -f
> > +endif
>
> Why adding a if BR2_PACKAGE_GETTEXT_GNU here ?
> We need to define GETTEXTIZE for gettextized packages (like host-flex).
>
> Currently the build is broken with:
>
> >>> host-flex 2.6.4 Gettextizing
> cd [...]/build/host-flex-2.6.4/ &&
> /bin/sh: -c: ligne 1: erreur de syntaxe : fin de fichier prématurée
> make[1]: *** [package/pkg-generic.mk:230:
> [...]/build/host-flex-2.6.4/.stamp_configured] Error 1
>

gettextizing is enabled depending on which provider is choosen
gettext-gnu or gettext-tiny, they
both provides GETTEXTIZE variable. The issue is caused on toolchains
which provides
BR2_TOOLCHAIN_HAS_FULL_GETTEXT=y, in that case gettext is not selected
by NLS config
and GETTEXTIZE is not defined. I will try to fix it ASAP.

Thanks for your findings!

Regards,
Vadim Kochan


More information about the buildroot mailing list