[Buildroot] [PATCH 04/10] infra/pkg-download: make the DOWNLOAD macro fully parameterised

Yann E. MORIN yann.morin.1998 at free.fr
Sun Apr 7 12:46:08 UTC 2019


All,

On 2019-04-07 13:51 +0200, Yann E. MORIN spake thusly:
> Change the macro to expect the upper-case package name as a
> parameter, rather than expect it from a variable.
[--SNIP--]
>  		$(patsubst %,-u %,$(call DOWNLOAD_URIS,$(1),$(PKG))) \
> +		$(patsubst %,-u %,$(call DOWNLOAD_URIS,$(1),$(2))) \

Of course, there was an incorrect rebase on that one. Fixed locally.

Regards,
Yann E. MORIN.

>  		$(QUIET) \
>  		-- \
> -		$($(PKG)_DL_OPTS)
> +		$($(2)_DL_OPTS)
>  endef
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index a83813e28d..f78ff2e665 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -149,7 +149,7 @@ $(BUILD_DIR)/%/.stamp_downloaded:
>  			break ; \
>  		fi ; \
>  	done
> -	$(foreach p,$($(PKG)_ALL_DOWNLOADS),$(call DOWNLOAD,$(p))$(sep))
> +	$(foreach p,$($(PKG)_ALL_DOWNLOADS),$(call DOWNLOAD,$(p),$(PKG))$(sep))
>  	$(foreach hook,$($(PKG)_POST_DOWNLOAD_HOOKS),$(call $(hook))$(sep))
>  	$(Q)mkdir -p $(@D)
>  	@$(call step_end,download)
> -- 
> 2.14.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'


More information about the buildroot mailing list