[Buildroot] [PATCH 1/1] package/freerdp: add h264 support
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Thu Apr 4 21:23:01 UTC 2019
Hello Alexey,
Thanks for your contribution!
On Thu, 4 Apr 2019 16:08:54 +0300
Alexey Lukyanchuk <skif at skif-web.ru> wrote:
> +config BR2_PACKAGE_FREERDP_H264
> + bool "h264 support"
> + depends on BR2_PACKAGE_X264
> + default y
> + help
> + h264 codec support for freerdp
> +
I think we would prefer to handle it like cups or ffmpeg, i.e as
"automatic dependencies", without an explicit Config.in option.
> +ifeq ($(BR2_PACKAGE_FREERDP_H264),y)
> + FREERDP_CONF_OPTS += -DWITH_GFX_H264=ON
> + FREERDP_DEPENDENCIES += x264
> +endif
i.e, make this:
ifeq ($(BR2_PACKAGE_X264),y)
FREERDP_CONF_OPTS += -DWITH_GFX_H264=ON
FREERDP_DEPENDENCIES += x264
else
FREERDP_CONF_OPTS += -DWITH_GFX_H264=OFF
endif
Could you rework your patch accordingly and send an updated version?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list