[Buildroot] [PATCH v2] qt5location: fix build failure due to missing qt5base gui dependency

[Giulio Benetti]

Hello,

Il 05/09/2018 15:02, Giulio Benetti ha scritto:
> Hello,
> 
> Il 05/09/2018 14:18, Thomas Petazzoni ha scritto:
>> Hello,
>>
>> On Wed, 5 Sep 2018 14:06:40 +0200, Giulio Benetti wrote:
>>
>>> The problem is that its configure.json depends on it
>>> https://github.com/qt/qtlocation/blob/5.11/src/location/configure.json#L3 
>>>
>>
>> OK, so it needs GUI support.
>>
>>> to check feature.opengl
>>> https://github.com/qt/qtlocation/blob/5.11/src/location/configure.json#L44 
>>>
>>
>> but OpenGL support is optional.
>>
>>> Also Qt Location is for creating mapping solutions:
>>> http://doc.qt.io/qt-5/qtlocation-index.html
>>> check i.e. examples:
>>> http://doc.qt.io/qt-5/qtlocation-examples.html
>>>
>>> So in the end, it seems it makes sense.
>>> In the beginning I thought it was a submodule to only get location
>>> parameters only.
>>
>> Yes, indeed.
>>
>>>> Also, having BR2_PACKAGE_QT5BASE_GUI does not guarantee that OpenGL
>>>> support is available, so I'm not sure this is going to fix the error in
>>>> all cases.
>>>
>>> I'm executing test-pkg -a right now, I'm on 3/47 passed, need some hour.
>>
>> Doing a test-pkg -a with the same configuration won't give any useful
>> result here. Remember that test-pkg is only testing different
>> *toolchain* configurations. It is not testing random configurations
>> with/without OpenGL.
> 
> Oops, you're right.
> Need to test with and without OpenGL package enabled.
> Anyway what takes care of opengl is exactly feature.opengl:
> https://github.com/qt/qtlocation/blob/5.11/src/location/configure.json#L44
> So it should work for every case.
> 
>>
>> For a change like this, a test-pkg -a is totally useless, however, a
>> test with just:
>>
>> BR2_PACKAGE_QT5BASE=y
>> BR2_PACKAGE_QT5LOCATION=y
> 
> In this case it doesn't fail, it provides automatically 
> BR2_PACKAGE_QT5BASE_GUI=y
> 
>>
>> which should fail, and then a test with just:
>>
>> BR2_PACKAGE_QT5BASE=y
>> BR2_PACKAGE_QT5BASE_GUI=y
>> BR2_PACKAGE_QT5LOCATION=y
>>
>> should work, with no other options selected (so no OpenGL support).
>>
> 
> Yes, it should, but I've done a mistake: I didn't take care about Qt 
> version. So need to rework the patch.

Sorry, not for this patch, for the other qt5location one:
https://patchwork.ozlabs.org/patch/966318/

Giulio