[Buildroot] [PATCH] synergy: change upstream location to fix download issues

Arnout Vandecappelle arnout at mind.be
Tue Sep 4 08:52:59 UTC 2018



On 04/09/2018 10:03, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 4 Sep 2018 00:25:27 +0200, Arnout Vandecappelle wrote:
> 
>>> My idea was to have it on master and next, but indeed I did not think
>>> about 2018.02.x/2018.05.x being broken :-/  
>>
>>  Wait, how are these broken? Quoting the commit message:
>>
>>    On master as of 811734ef9044bbdfc067da76358153061fae2031, we use
>>    v1.8.8, which fails to download from github.com, so we fallback to
>>    sources.buildroot.net, which has the tarball.
> 
> synergy is using version 1.8.8 since commit
> caa16c13e0fef18ae1142f502ee39d2af8f5172e, which was merged in 2017.05.
> 
>>>> Looking at the synergy git history, a hack could be to bump the version
>>>> to the commit just after v1.8.8 together with changing the URL so we end
>>>> up with a new tarball name:
>>>>
>>>> commit ec56ac4485ef8e3cf986107b8456949b5aec3527
>>>> Author: Andrew Nelless <andrew at symless.com>
>>>> Date:   Fri Mar 3 14:51:23 2017 +0000
>>>>
>>>>     Fix version number in Changelog  
>>>
>>> Or perhaps we simply don't fix it in master, and only in next ? The big
>>> downside I see with not fixing in master is that people who look at
>>> their build log will see the upstream download fail due to the hash
>>> mismatch, and the fallback to sources.buildroot.net.  
>>
>>  It's not a hash mismatch, it's a 404. So in my book, that's fine.
> 
> True. But if people fix to use the new upstream, then the hash becomes
> different. But perhaps that's OK.
> 
> So all in all, you're saying that we should keep it as-is in
> master/2018.02.x/2018.05.x, and simply change in next ?

 Yes, that's what I'm saying. Don't fix what's not broken. We have plenty of
other patches to apply :-)

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list