[Buildroot] [PATCH 2/2] lighttpd: add optional pam support

Matthew Weber matthew.weber at rockwellcollins.com
Tue Oct 30 12:43:45 UTC 2018


Peter,


On Tue, Oct 30, 2018 at 5:22 AM Peter Korsgaard <peter at korsgaard.com> wrote:
>
> Let the option depend on linux-pam as pam has quite some dependencies and
> this is unlikely to be used if pam isn't explicitly enabled.
>
> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
> ---
>  package/lighttpd/Config.in   | 7 +++++++
>  package/lighttpd/lighttpd.mk | 8 +++++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/package/lighttpd/Config.in b/package/lighttpd/Config.in
> index 383c10f70f..0f37422aea 100644
> --- a/package/lighttpd/Config.in
> +++ b/package/lighttpd/Config.in
> @@ -26,6 +26,13 @@ config BR2_PACKAGE_LIGHTTPD_OPENSSL
>         help
>           Enable OpenSSL support for lighttpd.
>
> +config BR2_PACKAGE_LIGHTTPD_PAM
> +       bool "pam authentication support"
> +       depends on BR2_PACKAGE_LINUX_PAM
> +       default y
> +       help
> +         Enable PAM authentication support for lighttpd.
> +
>  config BR2_PACKAGE_LIGHTTPD_ZLIB
>         bool "zlib support"
>         select BR2_PACKAGE_ZLIB
> diff --git a/package/lighttpd/lighttpd.mk b/package/lighttpd/lighttpd.mk
> index 44bee6f90f..d8f64dc7e8 100644
> --- a/package/lighttpd/lighttpd.mk
> +++ b/package/lighttpd/lighttpd.mk
> @@ -12,7 +12,6 @@ LIGHTTPD_LICENSE = BSD-3-Clause
>  LIGHTTPD_LICENSE_FILES = COPYING
>  LIGHTTPD_DEPENDENCIES = host-pkgconf
>  LIGHTTPD_CONF_OPTS = \
> -       --without-pam \
>         --without-wolfssl \
>         --libdir=/usr/lib/lighttpd \
>         --libexecdir=/usr/lib
> @@ -24,6 +23,13 @@ else
>  LIGHTTPD_CONF_OPTS += --without-openssl
>  endif
>
> +ifeq ($(BR2_PACKAGE_LIGHTTPD_PAM),y)
> +LIGHTTPD_DEPENDENCIES += linux-pam
> +LIGHTTPD_CONF_OPTS += --with-pam
> +else
> +LIGHTTPD_CONF_OPTS += --without-pam
> +endif

On the same note as Baruch, I dug through the code a bit and it looks
like enabling it just adds the mod_auth_pam support.  However a
configuration file still needs to call out using that support.  So it
looks like from a compatibility to old target builds perspective, this
can be enabled if PAM is present without any impact.

Matt


More information about the buildroot mailing list