[Buildroot] Queries/suggestions regarding patch series "grub2: add support for arm and aarch64"

Sumit Garg sumit.garg at linaro.org
Tue Oct 30 09:05:08 UTC 2018


Gentle reminder.

On Tue, 23 Oct 2018 at 11:28, Sumit Garg <sumit.garg at linaro.org> wrote:
>
> Hello Erico,
>
> Firstly, apologies for not posting these comments on your patch-set
> [1] as I joined Buildroot ML yesterday only.
>
> I was recently exploring to test EFI boot using Buildroot on qemu
> aarch64 target. But currently GRUB support is missing for aarch64
> target in Buildroot. So I came across your patch-set. I have tested
> your patch-set on qemu/u-boot aarch64 target using efi. So I would say
> its:
>
> Tested-by: Sumit Garg <sumit.garg at linaro.org>
>
> However, I will suggest you to use PARTUUID for root path in grub.cfg
> as it will make it more generic and device independent as we could use
> either virtio, sata, usb or mmc. So I would propose a similar change
> as in [2].
>
> Apart from that, how do you think about adding qemu/u-boot target for
> aarch64 to Buildroot? As u-boot already have efi booting support using
> bootefi.
>
> [1] https://patchwork.ozlabs.org/project/buildroot/list/?submitter=46481
>
> [2] Change:
>
> diff --git a/board/aarch64-efi/genimage-efi.cfg
> b/board/aarch64-efi/genimage-efi.cfg
> index f93ab9d..4a38bfe 100644
> --- a/board/aarch64-efi/genimage-efi.cfg
> +++ b/board/aarch64-efi/genimage-efi.cfg
> @@ -16,6 +16,7 @@ image efi-part.vfat {
>  image disk.img {
>
>    hdimage {
> +    disk-signature = 0xDEEDBEEF
>    }
>
>    partition boot {
> diff --git a/board/aarch64-efi/grub.cfg b/board/aarch64-efi/grub.cfg
> index ab88da9..404670b 100644
> --- a/board/aarch64-efi/grub.cfg
> +++ b/board/aarch64-efi/grub.cfg
> @@ -2,5 +2,5 @@ set default="0"
>  set timeout="5"
>
>  menuentry "Buildroot" {
> -       linux /Image root=/dev/vda2 rootwait console=ttyAMA0
> +       linux /Image root=PARTUUID=deedbeef-02 rootwait console=ttyAMA0
>  }
>
> Regards,
> Sumit


More information about the buildroot mailing list