[Buildroot] [PATCH 2/5] webkitgtk: add dependency on the woff2 package
Peter Korsgaard
peter at korsgaard.com
Thu Oct 11 18:19:28 UTC 2018
>>>>> "Adrian" == Adrian Perez de Castro <aperez at igalia.com> writes:
Hi,
>> Correct. Now that we have updated kconfig we could even consider using
>> the imply keyword to enable woff2 by default if it is really an option
>> that most people should enable:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=237e3ad0f195d8fd34f1299e45f04793832a16fc
> There's a small doubt I have here... How exactly would we prefer to have this?
> I can think of two options. One would be the following, and would allow to
> disable WOFF2 support in WebKitGTK+ even if the woff2 package is built:
> config BR2_PACKAGE_WEBKITGTK
> # ...
> imply BR2_PACKAGE_WEBKITGTK_WOFF2
> config BR2_PACKAGE_WEBKITGTK_WOFF2
> bool "woff2 support"
> depends on BR2_PACKAGE_WOFF2
> imply BR2_PACKAGE_WOFF2
> The other, simpler option, always enables WOFF2 support in WebKitGTK+ if the
> woff2 package can be built:
> config BR2_PACKAGE_WEBKITGTK
> # ...
> imply BR2_PACKAGE_WOFF2
I would go for the 2nd option. I cannot think of any sensible use cases
where we would want woff2 enabled but not use it in webkitgtk, and this
matches what we do elsewhere for E.G. openssl.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list