[Buildroot] [PATCH v2 1/4] pkg-waf: add support for <pkg>_SUBDIR

Lionel Orry lionel.orry at gmail.com
Thu Oct 11 12:58:09 UTC 2018


Hi Arnout,
On Thu, Oct 11, 2018 at 2:49 PM Arnout Vandecappelle <arnout at mind.be> wrote:
>
>
>
> On 11/10/18 11:57, Lionel Orry wrote:
> > diff --git a/package/pkg-waf.mk b/package/pkg-waf.mk
> > index 3288dd63a0..a32d5dab33 100644
> > --- a/package/pkg-waf.mk
> > +++ b/package/pkg-waf.mk
> > @@ -60,7 +60,7 @@ $(2)_WAF_OPTS                               ?=
> >  #
> >  ifndef $(2)_CONFIGURE_CMDS
> >  define $(2)_CONFIGURE_CMDS
> > -     cd $$(@D) && \
> > +     cd $$($$(PKG)_SRCDIR) && \
>
>  A little mistake on Thomas's part: this should be $$($$(PKG)_BUILDDIR), not
> $$($$(PKG)_SRCDIR). They are currently the same, but the idea is to introduce
> the possibility to do out-of-tree builds and to reuse the same source directory
> for host and target, and also for packages that share their source trees.

Actually in the case of waf, one needs to change to the directory
where the 'wscript' file is located, not in the directory where the
build output files are going to be generated.
By default, waf generates its output in a 'build/' subfolder relative
to the wscript, but this can be overriden in the wscript file and
using a command-line option as well.
So I believe we really want to change into $$($$(PKG)_SRCDIR). Do you agree?

>
>
>  Regards,
>  Arnout
>
> >       $$(TARGET_CONFIGURE_OPTS) \
> >       $$($(2)_CONF_ENV) \
> >       $$(HOST_DIR)/bin/python2 $$($(2)_WAF) configure \
>
> --
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list