[Buildroot] [PATCH 1/1] popt: add libiconv to popt.pc.in

Arnout Vandecappelle arnout at mind.be
Tue Nov 27 23:11:37 UTC 2018



On 22/11/2018 20:42, Fabrice Fontaine wrote:
> Add ${LTLIBICONV} to popt.pc.in so applications such as shairport-sync
> will know that they must link with -liconv when building statically
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/c5b0d1d2867e49c022a2ad971dd9f358ff0f3865

 Applied to master, thanks.

 I was going to suggest sending the patch upstream, but this is yet another dead
upstream...

 Regards,
 Arnout

> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  package/popt/0004-add-libiconv-to-popt.pc.patch | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 package/popt/0004-add-libiconv-to-popt.pc.patch
> 
> diff --git a/package/popt/0004-add-libiconv-to-popt.pc.patch b/package/popt/0004-add-libiconv-to-popt.pc.patch
> new file mode 100644
> index 0000000000..087a30bb7a
> --- /dev/null
> +++ b/package/popt/0004-add-libiconv-to-popt.pc.patch
> @@ -0,0 +1,19 @@
> +Add LTLIBICONV to popt.pc.in
> +
> +Add ${LTLIBICONV} to popt.pc.in so applications such as shairport-sync
> +will know that they must link with -liconv when building statically
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/c5b0d1d2867e49c022a2ad971dd9f358ff0f3865
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> +
> +diff -Naurp popt-1.16-vanilla/popt.pc.in popt-1.16/popt.pc.in
> +--- popt-1.16-vanilla/popt.pc.in	2018-11-22 20:26:55.735211662 +0100
> ++++ popt-1.16/popt.pc.in	2018-11-22 20:34:11.371303724 +0100
> +@@ -7,4 +7,5 @@ Name: popt
> + Version: @VERSION@
> + Description: popt library.
> + Libs: @POPT_PKGCONFIG_LIBS@
> ++Libs.private: @LTLIBICONV@
> + Cflags: -I${includedir}
> 


More information about the buildroot mailing list