[Buildroot] [PATCH v2] package/libtool: Reduce target package to libltdl only
Yann E. MORIN
yann.morin.1998 at free.fr
Sat Nov 24 18:47:08 UTC 2018
Alexander, All,
Arnout, licensing question for you at the end.
On 2018-11-24 17:54 +0100, Alexander Sverdlin spake thusly:
> This will save 1700K on target filesystem (as tested on ARM, i686).
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin at gmail.com>
> ---
> Changelog:
> v2:
> - rework target libtool instead of new package/libltdl
>
> package/libtool/libtool.mk | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/package/libtool/libtool.mk b/package/libtool/libtool.mk
> index bf97ee12b5..b25e058bf4 100644
> --- a/package/libtool/libtool.mk
> +++ b/package/libtool/libtool.mk
> @@ -7,12 +7,22 @@
> LIBTOOL_VERSION = 2.4.6
> LIBTOOL_SOURCE = libtool-$(LIBTOOL_VERSION).tar.xz
> LIBTOOL_SITE = $(BR2_GNU_MIRROR)/libtool
> +
> +LIBTOOL_SUBDIR = libltdl
> +HOST_LIBTOOL_SUBDIR = .
> +
> LIBTOOL_INSTALL_STAGING = YES
> -LIBTOOL_CONF_ENV = HELP2MAN=true
I guess HELP2MAN is no longer needed because there is no doc to build in
the libltdl subdir, right?
> +LIBTOOL_CONF_OPTS = --enable-ltdl-install
> +HOST_LIBTOOL_CONF_OPTS =
This host variable does inherit the value from the target variant, so
you don't need to specify an empty HOST_LIBTOOL_CONF_OPTS.
> LIBTOOL_DEPENDENCIES = host-m4
> HOST_LIBTOOL_DEPENDENCIES = host-m4
> -LIBTOOL_LICENSE = GPL-2.0+
> -LIBTOOL_LICENSE_FILES = COPYING
> +
> +LIBTOOL_LICENSE = LGPLv2.1
> +LIBTOOL_LICENSE_FILES = $(LIBTOOL_SUBDIR)/COPYING.LIB
> +HOST_LIBTOOL_LICENSE = GPL-2.0+
> +HOST_LIBTOOL_LICENSE_FILES = COPYING
So, the host presumably also builds libltdl, no? Thus, we should include
its licensing information too;
HOST_LIBTOOL_LICENSE = GPL-2.0+, LGPLv2.1 (libltdl)
HOST_LIBTOOL_LICENSE_FILES = COPYING $(LIBTOOL_SUBDIR)/COPYING.LIB
Not sure about that one, wait a bit for others to confirm before
respinning the patch.
Regards,
Yann E. MORIN.
> HOST_LIBTOOL_CONF_ENV = MAKEINFO=true
> HOST_LIBTOOL_LIBTOOL_PATCH = NO
> --
> 2.19.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list