[Buildroot] [PATCH v3] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML

Baruch Siach baruch at tkos.co.il
Fri Nov 16 04:38:10 UTC 2018


Commit fa0d1ebff99 (libnftnl: bump to version 1.0.9) removed the mxml
dependency. Remove the redundant BR2_PACKAGE_LIBNFTNL_XML config symbol
as well.

Cc: Yegor Yefremov <yegorslists at googlemail.com>
Signed-off-by: Baruch Siach <baruch at tkos.co.il>
---
v3: Remove the dependency comment as well

v2: Add Config.in.legacy entry (Thomas, Arnout)

Note: the legacy entry is under 2018.11. If this patch is backported to
stable branch it should probably move to an appropriate place per
branch.
---
 Config.in.legacy           |  5 +++++
 package/libnftnl/Config.in | 10 ----------
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/Config.in.legacy b/Config.in.legacy
index c3df37ddd9cb..9aafd624ea36 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -232,6 +232,11 @@ config BR2_KERNEL_HEADERS_4_17
 	  Version 4.17.x of the Linux kernel headers are no longer
 	  maintained upstream and are now removed.
 
+config BR2_PACKAGE_LIBNFTNL_XML
+	select BR2_LEGACY
+	help
+	  libnftnl removed integration with libmxml.
+
 ###############################################################################
 comment "Legacy options removed in 2018.08"
 
diff --git a/package/libnftnl/Config.in b/package/libnftnl/Config.in
index d4c9a1bb54e3..347223ce22a0 100644
--- a/package/libnftnl/Config.in
+++ b/package/libnftnl/Config.in
@@ -22,14 +22,4 @@ config BR2_PACKAGE_LIBNFTNL_JSON
 	help
 	  Enable JSON parsing support
 
-config BR2_PACKAGE_LIBNFTNL_XML
-	bool "enable XML support"
-	depends on BR2_TOOLCHAIN_HAS_THREADS
-	select BR2_PACKAGE_MXML
-	help
-	  Enable XML parsing support
-
-comment "libnftnl XML parsing support needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-
 endif
-- 
2.19.1



More information about the buildroot mailing list