[Buildroot] [PATCH 1/2] fs: Add common rootfs dependencies to PACKAGES

[Arnout Vandecappelle]

On 08/11/2018 14:04, Andreas Naumann wrote:
> Up to now only the filesystem-specific dependencies are explicitely
> added to PACKAGES. The common dependencies, e.g. host-fakeroot, were
> built indirectly via the rootfs-common/rootfs-tar dependency.
> 
> However, when switching to per-package host/target, we need to assemble
> the global host from the per-package folders. In order to do this by
> looping through PACKAGES, we need to directly add the common rootfs
> dependencies.
> That way then the filesystem recipes may continue to use these tools
> from the global host directory.
> 
> Signed-off-by: Andreas Naumann <anaumann at ultratronik.de>
> ---
>  fs/common.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/common.mk b/fs/common.mk
> index 2a5a202a89..a4a178c88a 100644
> --- a/fs/common.mk
> +++ b/fs/common.mk
> @@ -65,6 +65,7 @@ ROOTFS_COMMON_DEPENDENCIES = \
>  	host-fakeroot host-makedevs \
>  	$(BR2_TAR_HOST_DEPENDENCY) \
>  	$(if $(PACKAGES_USERS)$(ROOTFS_USERS_TABLES),host-mkpasswd)
> +PACKAGES += $(ROOTFS_COMMON_DEPENDENCIES)

 I don't really like this, for the simple reason that it will enable the
dependencies even if they are not needed because we're not building any rootfs.

 It's a small thing though, and working around it is a lot more complicated (you
could e.g. select a new Config.in symbol that is selected by all the rootfses).
And when we ever get the Config.in.host for all host packages, it's solved
already. So

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 Regards,
 Arnout

>  
>  $(ROOTFS_COMMON_TAR): ROOTFS=COMMON
>  $(ROOTFS_COMMON_TAR): FAKEROOT_SCRIPT=$(FS_DIR)/fakeroot.fs
>