[Buildroot] [PATCH] Config.in: security hardening: disable FORTIFY_SOURCE for gcc < 6

Romain Naour romain.naour at gmail.com
Tue Nov 6 21:06:27 UTC 2018


Le 06/11/2018 à 13:27, Matthew Weber a écrit :
> All,
> 
> On Mon, Nov 5, 2018 at 4:21 PM Matthew Weber
> <matthew.weber at rockwellcollins.com> wrote:
>>
>> Peter/Romain,
>>
>>
>> On Mon, Nov 5, 2018 at 4:17 PM Peter Korsgaard <peter at korsgaard.com> wrote:
>>>
>>>>>>>> "Matthew" == Matthew Weber <matthew.weber at rockwellcollins.com> writes:
>>>
>>>  > Romain ,
>>>  > On Mon, Nov 5, 2018, 14:07 Romain Naour <romain.naour at gmail.com wrote:
>>>
>>>  >> As reported in the bug report [1], gcc < 6 doesn't build when
>>>  >> FORTIFY_SOURCE is set to 1 or 2. The issue is related to the
>>>  >> upstream bug report [2] but the patch fixing the issue for gcc 6
>>>  >> has not been backported to earlier gcc versions.
>>>  >>
>>>  >> Add a dependency on gcc at least version 6 to BR2_FORTIFY_SOURCE_1
>>>  >> and BR2_FORTIFY_SOURCE_2.
>>>  >>
>>>
>>>  > Sorry about the HTML email.
>>>
>>>  > Could this dependency be conditional on if a internal toolchain is used?
>>>
>>> Ahh yes, if this is really about *building* gcc, then it should be
>>>
>>> depends on !BR2_TOOLCHAIN_BUILDROOT || BR2_TOOLCHAIN_GCC_AT_LEAST_6
>>>
>>
>> Correct.  I'll have to dig a bit and see what the minimum supported
>> external toolchain version is.  I believe 5.4.x
> 
> Found an old post....  https://access.redhat.com/blogs/766093/posts/1976213
> Looks like the FORTIFY options should work from GCC 4.0+ and is more
> dependent on GLIBC being new enough (which we won't run into).
> Macros are supported since GLIBC2.3.4 -
> http://man7.org/linux/man-pages/man7/feature_test_macros.7.html

Maybe it worth to backport this patch?

https://github.com/gcc-mirror/gcc/commit/55f12fce4ccf77513644a247f9c401a5b1fa2402

Best regards,
Romain

> 
> Matt
> 



More information about the buildroot mailing list