[Buildroot] [PATCH v2] xfsprogs: bump to 4.16.1

Baruch Siach baruch at tkos.co.il
Wed May 9 17:57:45 UTC 2018


Hi Matt,

On Wed, May 09, 2018 at 11:25:31AM -0500, Matthew Weber wrote:
> On Wed, May 9, 2018 at 11:14 AM, Baruch Siach <baruch at tkos.co.il> wrote:
> > On Wed, May 09, 2018 at 11:06:58AM -0500, Matt Weber wrote:
> >> diff --git a/package/xfsprogs/xfsprogs.mk b/package/xfsprogs/xfsprogs.mk
> >> index dffcc28..7f72f76 100644
> >> --- a/package/xfsprogs/xfsprogs.mk
> >> +++ b/package/xfsprogs/xfsprogs.mk
> >> @@ -4,7 +4,7 @@
> >>  #
> >>  ################################################################################
> >>
> >> -XFSPROGS_VERSION = 4.15.1
> >> +XFSPROGS_VERSION = 4.16.1
> >>  XFSPROGS_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/fs/xfs/xfsprogs
> >>  XFSPROGS_SOURCE = xfsprogs-$(XFSPROGS_VERSION).tar.xz
> >>  XFSPROGS_LICENSE = GPL-2.0, GPL-2.0+, LGPL-2.1 (libhandle, few headers)
> >> @@ -20,8 +20,8 @@ XFSPROGS_CONF_OPTS = \
> >>       INSTALL_GROUP=root \
> >>       --enable-static
> >>
> >> -ifeq ($(BR2_PACKAGE_LIBUNISTRING),y)
> >> -XFSPROGS_DEPENDENCIES += libunistring
> >> +ifeq ($(BR2_PACKAGE_ICU),y)
> >> +XFSPROGS_DEPENDENCIES += icu
> >
> > You should also add --{enable,disable}-libicu to XFSPROGS_CONF_OPTS as
> > appropriate.
> 
> I noticed the xfsprogs package is set to "Enable Unicode name scanning
> (libicu) default=probe", should we explicitly still do a
> enable/disable as the probe lines up with our Buildroot xfsprogs.mk
> dynamically enabling the dependency on icu?

We usually add explicit enable/disable to avoid accidental identification of 
host installed dependencies. This also makes failure to detect a dependency 
more apparent instead of a silent disable of dependency.

> If I do explicitly do an enable/disable.  Do you know if a
> --enable-libicu=yes/no is equivalent to the --{enable,disable}-libicu?

Yes, they are equivalent for AC_ARG_ENABLE(). I find the enable/disable 
variant more natural.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -


More information about the buildroot mailing list